Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc

Issue 2038083004: Reland of ExtensionFunction: don't pass ownership of base::Value by raw pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
diff --git a/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc b/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
index 98d79778f10374b0f92848c916b96110dcb60cc5..d5d38237fbe0cb448bf064f3239ca1ff5f428ca9 100644
--- a/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
+++ b/chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
@@ -6,6 +6,7 @@
#include <stddef.h>
+#include "base/memory/ptr_util.h"
#include "extensions/common/error_utils.h"
#include "net/base/registry_controlled_domains/registry_controlled_domain.h"
@@ -41,7 +42,8 @@
}
if (origin_url == app_id_url) {
- return RespondNow(OneArgument(new base::FundamentalValue(true)));
+ return RespondNow(
+ OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
}
// Fetch the eTLD+1 of both.
@@ -62,7 +64,8 @@
"Could not find an eTLD for appId *", params->app_id_url)));
}
if (origin_etldp1 == app_id_etldp1) {
- return RespondNow(OneArgument(new base::FundamentalValue(true)));
+ return RespondNow(
+ OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
}
// For legacy purposes, allow google.com origins to assert certain
// gstatic.com appIds.
@@ -72,11 +75,13 @@
i < sizeof(kGoogleGstaticAppIds) / sizeof(kGoogleGstaticAppIds[0]);
i++) {
if (params->app_id_url == kGoogleGstaticAppIds[i]) {
- return RespondNow(OneArgument(new base::FundamentalValue(true)));
+ return RespondNow(
+ OneArgument(base::MakeUnique<base::FundamentalValue>(true)));
}
}
}
- return RespondNow(OneArgument(new base::FundamentalValue(false)));
+ return RespondNow(
+ OneArgument(base::MakeUnique<base::FundamentalValue>(false)));
}
} // namespace api

Powered by Google App Engine
This is Rietveld 408576698