Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2038083003: 💫 target_cpu -> current_cpu in chromeos/BUILD.gn (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
Reviewers:
oshima, hashimoto
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@monochrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

target_cpu -> current_cpu in chromeos/BUILD.gn BUG=616819 Committed: https://crrev.com/c50a654e54c64a127782fca76e758fb1607fad14 Cr-Commit-Position: refs/heads/master@{#398773}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromeos/BUILD.gn View 2 chunks +2 lines, -2 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
agrieve
4 years, 6 months ago (2016-06-03 17:20:32 UTC) #2
oshima
https://codereview.chromium.org/2038083003/diff/1/chromeos/BUILD.gn File chromeos/BUILD.gn (right): https://codereview.chromium.org/2038083003/diff/1/chromeos/BUILD.gn#newcode50 chromeos/BUILD.gn:50: if (current_cpu == "arm" || current_cpu == "x86") { ...
4 years, 6 months ago (2016-06-03 19:04:32 UTC) #4
agrieve
On 2016/06/03 19:04:32, oshima wrote: > https://codereview.chromium.org/2038083003/diff/1/chromeos/BUILD.gn > File chromeos/BUILD.gn (right): > > https://codereview.chromium.org/2038083003/diff/1/chromeos/BUILD.gn#newcode50 > ...
4 years, 6 months ago (2016-06-08 17:10:10 UTC) #5
hashimoto
lgtm
4 years, 6 months ago (2016-06-09 01:11:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038083003/1
4 years, 6 months ago (2016-06-09 01:34:15 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 03:45:08 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 03:47:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c50a654e54c64a127782fca76e758fb1607fad14
Cr-Commit-Position: refs/heads/master@{#398773}

Powered by Google App Engine
This is Rietveld 408576698