Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2038013002: [runtime] Remove RUNTIME_ASSERT_HANDLIFIED. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove RUNTIME_ASSERT_HANDLIFIED. This removes the macro in question form the utility header. In the long run we want to convert all RUNTIME_ASSERTs to CHECKs, now that runtime functions are no longer fuzzed directly. This is just a first step. R=bmeurer@chromium.org BUG=v8:5066 Committed: https://crrev.com/960a87bbd5c59dea2ac7009be0ca288aee74c030 Cr-Commit-Position: refs/heads/master@{#36735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -23 lines) Patch
M src/runtime/runtime-debug.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/runtime/runtime-utils.h View 2 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-03 11:35:23 UTC) #4
Dan Ehrenberg
lgtm +100
4 years, 6 months ago (2016-06-03 12:56:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038013002/1
4 years, 6 months ago (2016-06-06 08:59:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 09:26:25 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 09:29:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/960a87bbd5c59dea2ac7009be0ca288aee74c030
Cr-Commit-Position: refs/heads/master@{#36735}

Powered by Google App Engine
This is Rietveld 408576698