Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2037973003: Fix resynthesis tests after dead code detection improvements. (Closed)

Created:
4 years, 6 months ago by Paul Berry
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix resynthesis tests after dead code detection improvements. Commit 38e8d9702bb6a02fcb640a8c42044e7455892eeb improved analyzer's detection of dead code, causing some of the test cases in resynthesize_test.dart to have dead code hints. This CL adds "allowErrors: true" to those tests so that they won't fail. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/86046f795bfd9deee655f4b6ce7fe827e4a11fa0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 6 months ago (2016-06-03 15:57:06 UTC) #2
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-03 16:09:37 UTC) #3
Paul Berry
4 years, 6 months ago (2016-06-03 16:20:02 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86046f795bfd9deee655f4b6ce7fe827e4a11fa0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698