Make ScriptRegexp for email address a member of EmailInputType.

Make ScriptRegexp for email address a member of EmailInputType.

Make it a data member of EmailInputType instead of a function-local static variable.

- Move EmailInputType constructor implementation to the .cpp file to void to include
  ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to convertEmailAddressToASCII() and
  isValidEmailAddress() and add createEmailRegexp() for ease of unit testing.

BUG=597530
Committed: https://crrev.com/fc3381f2aa9ccbb200f09d58ce34c22f7027491a
Cr-Commit-Position: refs/heads/master@{#397970}

[tkent, 2016-06-03 08:49:35]

Patchset #1 (id:1) has been deleted

[tkent, 2016-06-03 09:21:33]

Description was changed from

==========
Make ScriptRegexp for email address a member of EmailInputType.

BUG=597530
==========

to

==========
Make ScriptRegexp for email address a member of EmailInputType.

Make it a data member of EmailInputType instead of a function-local static
variable.

- Move EmailInputType constructor implementation to the .cpp file to void to
include
  ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to 

BUG=597530
==========

[tkent, 2016-06-03 09:22:36]

Description was changed from

==========
Make ScriptRegexp for email address a member of EmailInputType.

Make it a data member of EmailInputType instead of a function-local static
variable.

- Move EmailInputType constructor implementation to the .cpp file to void to
include
  ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to 

BUG=597530
==========

to

==========
Make ScriptRegexp for email address a member of EmailInputType.

Make it a data member of EmailInputType instead of a function-local static
variable.

- Move EmailInputType constructor implementation to the .cpp file to void to
include
  ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to convertEmailAddressToASCII() and
  isValidEmailAddress() and add createEmailRegexp() for ease of unit testing.

BUG=597530
==========

[tkent, 2016-06-03 09:37:18]

tkent@chromium.org changed reviewers:
+ hajimehoshi@chromium.org

[tkent, 2016-06-03 09:37:19]

hajimehoshi@, would you review this please?

[hajimehoshi, 2016-06-03 10:38:22]

look great with a nit.

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/EmailInputType.cpp (right):

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/EmailInputType.cpp:177:
m_emailRegexp.reset(createEmailRegexp().release());
I prefer std::move.

[haraken, 2016-06-03 12:12:28]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-06-03 12:12:29]

LGTM

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/EmailInputType.h (right):

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/EmailInputType.h:48:
EmailInputType(HTMLInputElement&);

Add explicit.

[tkent, 2016-06-06 02:51:55]

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/EmailInputType.cpp (right):

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/EmailInputType.cpp:177:
m_emailRegexp.reset(createEmailRegexp().release());
On 2016/06/03 at 10:38:22, hajimehoshi wrote:
> I prefer std::move.

Unfortunately, using std::move() here causes a compile error (error: moving a
temporary object prevents copy elision).
I update this line as following instead:
        m_emailRegexp = createEmailRegexp();

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/EmailInputType.h (right):

https://codereview.chromium.org/2037963002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/EmailInputType.h:48:
EmailInputType(HTMLInputElement&);
On 2016/06/03 at 12:12:28, haraken wrote:
> Add explicit.

Done.

[tkent, 2016-06-06 03:57:40]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-06-06 03:57:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2037963002/#ps40001
(title: "explicit, simplify ensureEmailRegexp()")

[commit-bot: I haz the power, 2016-06-06 03:57:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037963002/40001

[commit-bot: I haz the power, 2016-06-06 04:34:24]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-06 04:35:43]

Description was changed from

==========
Make ScriptRegexp for email address a member of EmailInputType.

Make it a data member of EmailInputType instead of a function-local static
variable.

- Move EmailInputType constructor implementation to the .cpp file to void to
include
  ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to convertEmailAddressToASCII() and
  isValidEmailAddress() and add createEmailRegexp() for ease of unit testing.

BUG=597530
==========

to

==========
Make ScriptRegexp for email address a member of EmailInputType.

Make it a data member of EmailInputType instead of a function-local static
variable.

- Move EmailInputType constructor implementation to the .cpp file to void to
include
  ScriptRegexp.h in EmailInputType.h.
- Add ScriptRegexp arguments to convertEmailAddressToASCII() and
  isValidEmailAddress() and add createEmailRegexp() for ease of unit testing.

BUG=597530

Committed: https://crrev.com/fc3381f2aa9ccbb200f09d58ce34c22f7027491a
Cr-Commit-Position: refs/heads/master@{#397970}
==========

[commit-bot: I haz the power, 2016-06-06 04:35:44]

Patchset 2 (id:??) landed as
https://crrev.com/fc3381f2aa9ccbb200f09d58ce34c22f7027491a
Cr-Commit-Position: refs/heads/master@{#397970}