Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037943002: Promises: Reorder heap symbols alphabetically (Closed)

Created:
4 years, 6 months ago by gsathya
Modified:
4 years, 6 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Promises: Reorder heap symbols alphabetically R=littledan@chromium.org Committed: https://crrev.com/cfe77e13177b78c2467ed38671d461396c7fbcfe Cr-Commit-Position: refs/heads/master@{#36717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap-symbols.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
gsathya
4 years, 6 months ago (2016-06-03 05:49:05 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037943002/1
4 years, 6 months ago (2016-06-03 05:49:24 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-03 06:19:13 UTC) #5
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-03 13:26:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037943002/1
4 years, 6 months ago (2016-06-03 15:12:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 15:14:59 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 15:16:36 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cfe77e13177b78c2467ed38671d461396c7fbcfe
Cr-Commit-Position: refs/heads/master@{#36717}

Powered by Google App Engine
This is Rietveld 408576698