Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2037933003: Prefer device type instead of machine name for scale factor overrides. (Closed)

Created:
4 years, 6 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 6 months ago
Reviewers:
Zhenyao Mo, ynovikov
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefer device type instead of machine name for scale factor overrides. This will make the Maps test work on Android bots on the commit queue. BUG=616297 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/030567f42e184ee7297809c7621d8867887e7221 Cr-Commit-Position: refs/heads/master@{#397868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M content/test/gpu/gpu_tests/cloud_storage_test_base.py View 3 chunks +29 lines, -17 lines 0 comments Download
M content/test/gpu/gpu_tests/gpu_rasterization.py View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/maps.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/pixel.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/page_sets/data/maps_004_expectations.json View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Ken Russell (switch to Gerrit)
ynovikov: please review. Tested locally on a Nexus 6. zmo: FYI. Please feel free to ...
4 years, 6 months ago (2016-06-03 21:40:40 UTC) #3
Ken Russell (switch to Gerrit)
Note: on all desktop platforms the device type name returns "Desktop". That should be OK ...
4 years, 6 months ago (2016-06-03 21:41:38 UTC) #4
Zhenyao Mo
On 2016/06/03 21:41:38, Ken Russell wrote: > Note: on all desktop platforms the device type ...
4 years, 6 months ago (2016-06-03 21:46:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037933003/1
4 years, 6 months ago (2016-06-03 21:49:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 00:52:19 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:54:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/030567f42e184ee7297809c7621d8867887e7221
Cr-Commit-Position: refs/heads/master@{#397868}

Powered by Google App Engine
This is Rietveld 408576698