Fixing invalid visibility states with layers (opacity==0, visibility==true)

ash/wm/system_modal_container_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/system_modal_container_layout_manager.h"
 
 #include "ash/session_state_delegate.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/system_modal_container_event_filter.h"
@@ skipping 147 matching lines @@
     views::View* contents_view = new views::View();
     // TODO(jamescook): This could be SK_ColorWHITE for the new dialog style.
     contents_view->set_background(
         views::Background::CreateSolidBackground(SK_ColorBLACK));
     modal_background_->SetContentsView(contents_view);
     modal_background_->GetNativeView()->layer()->SetOpacity(0.0f);
   }
 
   ui::ScopedLayerAnimationSettings settings(
       modal_background_->GetNativeView()->layer()->GetAnimator());
+  // Show should not be called with a target opacity of 0. We therefore start
+  // the fade to show animation before Show() is called.
+  modal_background_->GetNativeView()->layer()->SetOpacity(0.5f);
   modal_background_->Show();
-  modal_background_->GetNativeView()->layer()->SetOpacity(0.5f);
   container_->StackChildAtTop(modal_background_->GetNativeView());
 }
 
 void SystemModalContainerLayoutManager::DestroyModalBackground() {
   // modal_background_ can be NULL when a root window is shutting down
   // and OnWindowDestroying is called first.
   if (modal_background_) {
     ui::ScopedLayerAnimationSettings settings(
         modal_background_->GetNativeView()->layer()->GetAnimator());
     modal_background_->Close();
@@ skipping 35 matching lines @@
 void SystemModalContainerLayoutManager::RemoveModalWindow(
     aura::Window* window) {
   aura::Window::Windows::iterator it =
       std::find(modal_windows_.begin(), modal_windows_.end(), window);
   if (it != modal_windows_.end())
     modal_windows_.erase(it);
 }
 
 }  // namespace internal
 }  // namespace ash