Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2037923002:
Set value of always_show_context_menu_on_touch in WebSettings (Closed)
|
Created:
4 years, 6 months ago by amaralp Modified:
4 years, 6 months ago CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet value of always_show_context_menu_on_touch in WebSettings
Previous CL forgot to set the value of always_show_context_menu_on_touch.
This CL fixes that.
BUG=616971
Committed: https://crrev.com/547e419023c4ee52ab8772464f1c678e0bbb9924
Cr-Commit-Position: refs/heads/master@{#397774}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Set value of always_show_context_menu_on_touch in WebSettings Previous CL forgot to set the value of always_show_context_menu_on_touch. This CL fixes that. BUG=616971 ========== to ========== Set value of always_show_context_menu_on_touch in WebSettings Previous CL forgot to set the value of always_show_context_menu_on_touch. This CL fixes that. BUG=616971 ==========
amaralp@chromium.org changed reviewers: + aelias@chromium.org
On 2016/06/03 00:55:42, amaralp wrote: > mailto:amaralp@chromium.org changed reviewers: > + mailto:aelias@chromium.org PTAL
lgtm
The CQ bit was checked by amaralp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
amaralp@chromium.org changed reviewers: + sievers@chromium.org
On 2016/06/03 18:45:00, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Added sievers@ for src/content OWNER lgtm
On 2016/06/03 18:57:13, amaralp wrote: > On 2016/06/03 18:45:00, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > Added sievers@ for src/content OWNER lgtm lgtm
The CQ bit was checked by amaralp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037923002/1
Message was sent while issue was closed.
Description was changed from ========== Set value of always_show_context_menu_on_touch in WebSettings Previous CL forgot to set the value of always_show_context_menu_on_touch. This CL fixes that. BUG=616971 ========== to ========== Set value of always_show_context_menu_on_touch in WebSettings Previous CL forgot to set the value of always_show_context_menu_on_touch. This CL fixes that. BUG=616971 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Set value of always_show_context_menu_on_touch in WebSettings Previous CL forgot to set the value of always_show_context_menu_on_touch. This CL fixes that. BUG=616971 ========== to ========== Set value of always_show_context_menu_on_touch in WebSettings Previous CL forgot to set the value of always_show_context_menu_on_touch. This CL fixes that. BUG=616971 Committed: https://crrev.com/547e419023c4ee52ab8772464f1c678e0bbb9924 Cr-Commit-Position: refs/heads/master@{#397774} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/547e419023c4ee52ab8772464f1c678e0bbb9924 Cr-Commit-Position: refs/heads/master@{#397774} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
