| Index: chrome/browser/enumerate_modules_model_unittest_win.cc
|
| diff --git a/chrome/browser/enumerate_modules_model_unittest_win.cc b/chrome/browser/enumerate_modules_model_unittest_win.cc
|
| index 6f084d543f65ca4256f5dd35a02ff3d1a8064b8a..5f7d743c6552cce42366e02618ca94e243c40ef5 100644
|
| --- a/chrome/browser/enumerate_modules_model_unittest_win.cc
|
| +++ b/chrome/browser/enumerate_modules_model_unittest_win.cc
|
| @@ -101,115 +101,6 @@ static const char kVersionLow[] = "0.5";
|
| static const char kMatchSignature[] = "7bfd87e1"; // "Sig".
|
| static const char kEmpty[] = "";
|
|
|
| -const struct MatchingEntryList {
|
| - ModuleEnumerator::ModuleStatus expected_result;
|
| - ModuleEnumerator::Module test_case;
|
| - ModuleEnumerator::BlacklistEntry blacklist;
|
| -} kMatchineEntryList[] = {
|
| - // Each BlacklistEntry is:
|
| - // Filename, location, desc_or_signer, version from, version to, help_tip.
|
| -
|
| - { // Matches: Name (location doesn't match) => Not enough for a match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - kStandardModule,
|
| - { kMatchName, kNoMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name (location not given) => Suspected match.
|
| - ModuleEnumerator::SUSPECTED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kEmpty, kEmpty, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, not version (location not given) => Not a match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - kStandardModule,
|
| - { kMatchName, kEmpty, kEmpty, kVersionHigh, kVersionHigh, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location => Suspected match.
|
| - ModuleEnumerator::SUSPECTED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, (description not given) => Confirmed match.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModuleNoDescription, // Note: No description.
|
| - { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, (signature not given) => Confirmed match.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModuleNoSignature, // Note: No signature.
|
| - { kMatchName, kMatchLocation, kEmpty, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location (not version) => Not a match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kEmpty, kVersionHigh, kVersionLow, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, signature => Confirmed match.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchSignature, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, signature (not version) => No match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchSignature,
|
| - kVersionLow, kVersionLow, kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, description => Confirmed match.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchDesc, kEmpty, kEmpty, kOs,
|
| - ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, description (not version) => No match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchDesc,
|
| - kVersionHigh, kVersionHigh, kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, signature, version => Confirmed match.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchSignature,
|
| - kVersionLow, kVersionHigh, kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, signature, version (lower) => Confirmed.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchSignature,
|
| - kVersionLow, kEmpty, kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, location, signature, version (upper) => Confirmed.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchSignature,
|
| - kEmpty, kVersionHigh, kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, Location, Version lower is inclusive => Confirmed.
|
| - ModuleEnumerator::CONFIRMED_BAD,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kMatchSignature,
|
| - "1.0", "2.0", kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // Matches: Name, Location, Version higher is exclusive => No match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - kStandardModule,
|
| - { kMatchName, kMatchLocation, kEmpty,
|
| - "0.0", "1.0", kOs, ModuleEnumerator::SEE_LINK }
|
| - }, { // All empty fields doesn't produce a match.
|
| - ModuleEnumerator::NOT_MATCHED,
|
| - { kType, kStatus, L"", L"", L"", L"", L"", L"", ModuleEnumerator::NONE },
|
| - { "a.dll", "", "", "", "", kOs, ModuleEnumerator::SEE_LINK }
|
| - },
|
| -};
|
| -
|
| -TEST_F(EnumerateModulesTest, MatchFunction) {
|
| - for (size_t i = 0; i < arraysize(kMatchineEntryList); ++i) {
|
| - ModuleEnumerator::Module test = kMatchineEntryList[i].test_case;
|
| - ModuleEnumerator::NormalizeModule(&test);
|
| - ModuleEnumerator::BlacklistEntry blacklist =
|
| - kMatchineEntryList[i].blacklist;
|
| -
|
| - SCOPED_TRACE("Test case no " + base::IntToString(i) +
|
| - ": '" + base::UTF16ToASCII(test.name) + "'");
|
| - EXPECT_EQ(kMatchineEntryList[i].expected_result,
|
| - ModuleEnumerator::Match(test, blacklist));
|
| - }
|
| -}
|
| -
|
| const struct CollapsePathList {
|
| base::string16 expected_result;
|
| base::string16 test_case;
|
|
|