[Win] Add reporting of total number of modules loaded in browser process.

chrome/browser/ui/toolbar/app_menu_model.cc

Index: chrome/browser/ui/toolbar/app_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/app_menu_model.cc b/chrome/browser/ui/toolbar/app_menu_model.cc
index 3c01b65d1db0de8d3efe155b7c09880b827f4687..dd41a359869e114110cffc623632db04922828cf 100644
--- a/chrome/browser/ui/toolbar/app_menu_model.cc
+++ b/chrome/browser/ui/toolbar/app_menu_model.cc
@@ -684,16 +684,8 @@ bool AppMenuModel::IsCommandIdVisible(int command_id) const {
       return false;  // Always hidden (see CreateActionToolbarOverflowMenu).
 #endif
 #if defined(OS_WIN)
-    case IDC_VIEW_INCOMPATIBILITIES: {
-      EnumerateModulesModel* loaded_modules =
-          EnumerateModulesModel::GetInstance();
-      if (loaded_modules->confirmed_bad_modules_detected() <= 0)
-        return false;
-      // We'll leave the app menu adornment on until the user clicks the link.
-      if (loaded_modules->modules_to_notify_about() <= 0)
-        loaded_modules->AcknowledgeConflictNotification();
-      return true;
-    }
+    case IDC_VIEW_INCOMPATIBILITIES:
+      return EnumerateModulesModel::GetInstance()->ShouldShowConflictWarning();
     case IDC_PIN_TO_START_SCREEN:
       return false;

[Peter Kasting, 2016/08/05 00:10:08]

Nit: Could factor IDC_PIN_TO_START_SCREEN out of the #ifdef since both
implementations are the same.  The absolute most compact way (although this is a
bit fragile, and you might not choose to do it) would be:

    case IDC_VIEW_INCOMPATIBILITIES:
#if defined(OS_WIN)
      return EnumerateModulesModel::GetInstance()->ShouldShowConflictWarning();
#endif
    case IDC_PIN_TO_START_SCREEN:
      return false;

If that makes you uneasy, the simpler route would be to just explicitly do:

    case IDC_VIEW_INCOMPATIBILITIES:
#if defined(OS_WIN)
      return EnumerateModulesModel::GetInstance()->ShouldShowConflictWarning();
#else
      return false;
#endif
    case IDC_PIN_TO_START_SCREEN:
      return false;

[chrisha, 2016/08/12 19:04:40]

Thanks for the suggestion. Went the less fragile route.

 #else