[Win] Add reporting of total number of modules loaded in browser process.

chrome/browser/ui/toolbar/app_menu_icon_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_TOOLBAR_APP_MENU_ICON_CONTROLLER_H_
 #define CHROME_BROWSER_UI_TOOLBAR_APP_MENU_ICON_CONTROLLER_H_
 
 #include "base/macros.h"
 #include "chrome/browser/ui/toolbar/app_menu_icon_painter.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 
+#if defined(OS_WIN)

[Peter Kasting, 2016/08/05 00:10:08]

Nit: Consider whether it might be cleaner to have at least the Observer class
from here defined in a not-win-specific file.  This would let you avoid all the
ifdefs in this file and at least some in the .cc file.

You may decide that it's worth keeping the ifdefs here, to emphasize that none
of this functionality is reached in non-Windows.  On the other end, you might go
all the way to making EnumerateModulesModel itself be declared in cross-platform
files, and only ever actually do anything when run on Windows, which would
remove all the ifdefs from here and the .cc file.  This would depend partly on
the degree of "black-boxing" you want for that class, and how much callers
should know about what it does and why we care about it.  It would also depend
on whether it would ever make sense conceptually to run such code on other OSes.

[chrisha, 2016/08/12 19:04:40]

I'll stick with the existing system for now. I think it makes sense to make the
definition available across platforms if it ever becomes used across more than
one of them, and have left a comment to that effect.

+#include "chrome/browser/win/enumerate_modules_model.h"
+#endif
+
 class Profile;
 
 // AppMenuIconController encapsulates the logic for badging the app menu icon
 // as a result of various events - such as available updates, errors, etc.
-class AppMenuIconController : public content::NotificationObserver {
+class AppMenuIconController :
+#if defined(OS_WIN)
+    public EnumerateModulesModel::Observer,
+#endif
+    public content::NotificationObserver {
  public:
   enum class IconType {
     NONE,
     UPGRADE_NOTIFICATION,
     GLOBAL_ERROR,
     INCOMPATIBILITY_WARNING,
   };
 
   // Delegate interface for receiving icon update notifications.
   class Delegate {
@@ skipping 19 matching lines @@
   // etc. and based on that information trigger an appropriate call to the
   // delegate.
   void UpdateDelegate();
 
  private:
   // content::NotificationObserver:
   void Observe(int type,
                const content::NotificationSource& source,
                const content::NotificationDetails& details) override;
 
+#if defined(OS_WIN)
+  // EnumerateModulesModel:
+  void OnScanCompleted() override;
+  void OnConflictsAcknowledged() override;
+#endif
+
   Profile* profile_;
   Delegate* delegate_;
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(AppMenuIconController);
 };
 
 #endif  // CHROME_BROWSER_UI_TOOLBAR_APP_MENU_ICON_CONTROLLER_H_