Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2037883002: Remove XP-specific logic in url_request_unittest.cc. (Closed)

Created:
4 years, 6 months ago by davidben
Modified:
4 years, 6 months ago
Reviewers:
svaldez
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove XP-specific logic in url_request_unittest.cc. There is no longer a need to filter out ECDSA. BUG=none Committed: https://crrev.com/7ee23543093c373d01d59784f533bb7e7efdd419 Cr-Commit-Position: refs/heads/master@{#397762}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -60 lines) Patch
M net/url_request/url_request_unittest.cc View 1 5 chunks +2 lines, -60 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
davidben
4 years, 6 months ago (2016-06-02 23:20:27 UTC) #2
svaldez
lgtm https://codereview.chromium.org/2037883002/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2037883002/diff/1/net/url_request/url_request_unittest.cc#newcode9267 net/url_request/url_request_unittest.cc:9267: #elif defined(OS_WIN) nit: Just remove the OS_WIN branch.
4 years, 6 months ago (2016-06-03 14:57:28 UTC) #3
davidben
https://codereview.chromium.org/2037883002/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/2037883002/diff/1/net/url_request/url_request_unittest.cc#newcode9267 net/url_request/url_request_unittest.cc:9267: #elif defined(OS_WIN) On 2016/06/03 14:57:28, svaldez wrote: > nit: ...
4 years, 6 months ago (2016-06-03 16:38:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037883002/20001
4 years, 6 months ago (2016-06-03 18:22:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 18:27:57 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:30:44 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ee23543093c373d01d59784f533bb7e7efdd419
Cr-Commit-Position: refs/heads/master@{#397762}

Powered by Google App Engine
This is Rietveld 408576698