Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2037863002: Remove FDE_HDEVICESTATE handle type (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FDE_HDEVICESTATE handle type There's only one way to get one of these, and its always NULL, so no need to pass around.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M xfa/fde/fde_gedevice.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fde/fde_gedevice.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fde/fde_render.h View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fde/fde_render.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Tom Sepez
Lei, more unused code.
4 years, 6 months ago (2016-06-02 21:39:13 UTC) #2
Tom Sepez
4 years, 6 months ago (2016-06-06 19:03:40 UTC) #3
Message was sent while issue was closed.
Superseded by https://codereview.chromium.org/2044623002/

Powered by Google App Engine
This is Rietveld 408576698