components/plugins/renderer/webview_plugin.cc - Issue 2037843002: Remove use of deprecated MessageLoop methods in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/webview_plugin.cc

Issue 2037843002: Remove use of deprecated MessageLoop methods in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change precache Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client_browsertest.cc ('k') | components/precache/content/precache_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/webview_plugin.cc

diff --git a/components/plugins/renderer/webview_plugin.cc b/components/plugins/renderer/webview_plugin.cc

index 968ed150b44deff6e63b364327ce8b52663b2cd6..e60501a1abdee6f15576ae23113cf4330ff46379 100644

--- a/components/plugins/renderer/webview_plugin.cc

+++ b/components/plugins/renderer/webview_plugin.cc

@@ -7,9 +7,11 @@

#include <stddef.h>

#include "base/auto_reset.h"

-#include "base/message_loop/message_loop.h"

+#include "base/location.h"

#include "base/metrics/histogram_macros.h"

#include "base/numerics/safe_conversions.h"

+#include "base/single_thread_task_runner.h"

+#include "base/threading/thread_task_runner_handle.h"

#include "content/public/common/web_preferences.h"

#include "content/public/renderer/render_view.h"

#include "gin/converter.h"

@@ -156,7 +158,7 @@ void WebViewPlugin::destroy() {

}

container_ = nullptr;

content::RenderViewObserver::Observe(nullptr);

- base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);

+ base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);

}

v8::Local<v8::Object> WebViewPlugin::v8ScriptableObject(v8::Isolate* isolate) {