Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2037833003: Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //dbus (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
stevenjb, hashimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ListValue::Append(new {Fundamental,String}Value(...)) pattern in //dbus The raw pointer overload of ListValue::Append() is deprecated and will be removed. Instead, code should just write: - ListValue::AppendBoolean() - ListValue::AppendInteger() - ListValue::AppendDouble() - ListValue::AppendString() BUG=581865 Committed: https://crrev.com/4f046e8566d5fc9b8ad8f1e1bed20422bbab36e3 Cr-Commit-Position: refs/heads/master@{#398228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M dbus/values_util_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
4 years, 6 months ago (2016-06-02 22:20:12 UTC) #2
dcheng
ping
4 years, 6 months ago (2016-06-06 18:05:49 UTC) #3
dcheng
+hashimoto, can you review?
4 years, 6 months ago (2016-06-07 03:59:22 UTC) #5
hashimoto
lgtm
4 years, 6 months ago (2016-06-07 04:05:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037833003/1
4 years, 6 months ago (2016-06-07 04:07:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 05:05:26 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 05:06:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f046e8566d5fc9b8ad8f1e1bed20422bbab36e3
Cr-Commit-Position: refs/heads/master@{#398228}

Powered by Google App Engine
This is Rietveld 408576698