Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issue 2037833002: [MD Settings Passwords] Make password exceptions copy-able. (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Settings Passwords] Make password exceptions copy-able. No visible UI change, just making the exception url copy-able. BUG=595538 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b43cf3a459557f660757c8f261c523b222a894df Cr-Commit-Position: refs/heads/master@{#397551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
hcarmona
PTAL, Thanks!
4 years, 6 months ago (2016-06-02 20:54:44 UTC) #3
dschuyler
lgtm
4 years, 6 months ago (2016-06-02 23:25:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037833002/1
4 years, 6 months ago (2016-06-02 23:53:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-03 00:07:54 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 00:11:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b43cf3a459557f660757c8f261c523b222a894df
Cr-Commit-Position: refs/heads/master@{#397551}

Powered by Google App Engine
This is Rietveld 408576698