Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1254)

Unified Diff: runtime/vm/uri_test.cc

Issue 2037823003: Make ResolveUri return the correct target_uri for relative base uris. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/uri.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/uri_test.cc
diff --git a/runtime/vm/uri_test.cc b/runtime/vm/uri_test.cc
index a0cf153a373237a399e7ab681c812173117e3aa1..d0b99ab2b2e1589484dfa65553aeb1fb0d3c8663 100644
--- a/runtime/vm/uri_test.cc
+++ b/runtime/vm/uri_test.cc
@@ -562,25 +562,25 @@ TEST_CASE(ResolveUri_NormalizeEscapes_BrokenEscapeSequence) {
TEST_CASE(ResolveUri_RelativeBase_NotImplemented) {
const char* target_uri;
EXPECT(!ResolveUri("../r1", "b1/b2", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
EXPECT(!ResolveUri("..", "b1/b2", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
EXPECT(!ResolveUri("../..", "b1/b2", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
EXPECT(!ResolveUri("../../..", "b1/b2", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
EXPECT(!ResolveUri("../../../r1", "b1/b2", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
EXPECT(!ResolveUri("../r1", "../../b1/b2/b3", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
EXPECT(!ResolveUri("../../../r1", "../../b1/b2/b3", &target_uri));
- EXPECT_STREQ("", target_uri);
+ EXPECT(target_uri == NULL);
}
« no previous file with comments | « runtime/vm/uri.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698