Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: ui/gl/init/gl_factory_mac.cc

Issue 2037793002: Move GLContext creation from //ui/gl to //ui/gl/init. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gl_init
Patch Set: Change to scoped_refptr. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gl/init/gl_factory_android.cc ('k') | ui/gl/init/gl_factory_ozone.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <memory> 5 #include "ui/gl/init/gl_factory.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/trace_event/trace_event.h" 8 #include "base/trace_event/trace_event.h"
9 #include "ui/gl/gl_context_cgl.h" 9 #include "ui/gl/gl_context_cgl.h"
10 #include "ui/gl/gl_context_osmesa.h" 10 #include "ui/gl/gl_context_osmesa.h"
11 #include "ui/gl/gl_context_stub.h" 11 #include "ui/gl/gl_context_stub.h"
12 #include "ui/gl/gl_implementation.h" 12 #include "ui/gl/gl_implementation.h"
13 #include "ui/gl/gl_share_group.h"
13 #include "ui/gl/gl_surface.h" 14 #include "ui/gl/gl_surface.h"
14 #include "ui/gl/gl_switches.h"
15 15
16 namespace gl { 16 namespace gl {
17 namespace init {
17 18
18 class GLShareGroup; 19 scoped_refptr<GLContext> CreateGLContext(GLShareGroup* share_group,
19 20 GLSurface* compatible_surface,
20 scoped_refptr<GLContext> GLContext::CreateGLContext( 21 GpuPreference gpu_preference) {
21 GLShareGroup* share_group, 22 TRACE_EVENT0("gpu", "gl::init::CreateGLContext");
22 GLSurface* compatible_surface,
23 GpuPreference gpu_preference) {
24 TRACE_EVENT0("gpu", "GLContext::CreateGLContext");
25 switch (GetGLImplementation()) { 23 switch (GetGLImplementation()) {
26 case kGLImplementationDesktopGL: 24 case kGLImplementationDesktopGL:
27 case kGLImplementationDesktopGLCoreProfile: 25 case kGLImplementationDesktopGLCoreProfile:
28 case kGLImplementationAppleGL: { 26 case kGLImplementationAppleGL:
29 scoped_refptr<GLContext> context;
30 // Note that with virtualization we might still be able to make current 27 // Note that with virtualization we might still be able to make current
31 // a different onscreen surface with this context later. But we should 28 // a different onscreen surface with this context later. But we should
32 // always be creating the context with an offscreen surface first. 29 // always be creating the context with an offscreen surface first.
33 DCHECK(compatible_surface->IsOffscreen()); 30 DCHECK(compatible_surface->IsOffscreen());
34 context = new GLContextCGL(share_group); 31 return InitializeGLContext(new GLContextCGL(share_group),
35 if (!context->Initialize(compatible_surface, gpu_preference)) 32 compatible_surface, gpu_preference);
36 return NULL; 33 case kGLImplementationOSMesaGL:
37 34 return InitializeGLContext(new GLContextOSMesa(share_group),
38 return context; 35 compatible_surface, gpu_preference);
39 }
40 case kGLImplementationOSMesaGL: {
41 scoped_refptr<GLContext> context(new GLContextOSMesa(share_group));
42 if (!context->Initialize(compatible_surface, gpu_preference))
43 return NULL;
44
45 return context;
46 }
47 case kGLImplementationMockGL: 36 case kGLImplementationMockGL:
48 return new GLContextStub(share_group); 37 return new GLContextStub(share_group);
49 default: 38 default:
50 NOTREACHED(); 39 NOTREACHED();
51 return NULL; 40 return nullptr;
52 } 41 }
53 } 42 }
54 43
44 } // namespace init
55 } // namespace gl 45 } // namespace gl
OLDNEW
« no previous file with comments | « ui/gl/init/gl_factory_android.cc ('k') | ui/gl/init/gl_factory_ozone.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698