Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037773003: Make ChannelMojo compile under NaCl. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ChannelMojo compile under NaCl. BUG=604282 Committed: https://crrev.com/e309ea31991fb48a256e69c4f03b1c631e07f1b8 Cr-Commit-Position: refs/heads/master@{#397964}

Patch Set 1 #

Patch Set 2 : Windows build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ipc/mojo/ipc_channel_mojo.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-06-03 04:40:19 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-06 02:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037773003/20001
4 years, 6 months ago (2016-06-06 03:17:29 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 03:21:24 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 03:24:14 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e309ea31991fb48a256e69c4f03b1c631e07f1b8
Cr-Commit-Position: refs/heads/master@{#397964}

Powered by Google App Engine
This is Rietveld 408576698