Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037763002: [ios] Cleanup resource bundle in WebTestSuite::Shutdown. (Closed)

Created:
4 years, 6 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 6 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Cleanup resource bundle in WebTestSuite::Shutdown. BUG=None Committed: https://crrev.com/82ed2a35b3a0c8f7398fb3e5ad36577774dced8b Cr-Commit-Position: refs/heads/master@{#397881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ios/web/test/web_test_suite.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/test/web_test_suite.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Eugene But (OOO till 7-30)
4 years, 6 months ago (2016-06-02 18:03:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037763002/1
4 years, 6 months ago (2016-06-02 18:05:18 UTC) #4
Jackie Quinn
lgtm
4 years, 6 months ago (2016-06-02 19:22:34 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/240093)
4 years, 6 months ago (2016-06-02 21:20:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037763002/1
4 years, 6 months ago (2016-06-02 21:35:11 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/240345)
4 years, 6 months ago (2016-06-03 00:53:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037763002/1
4 years, 6 months ago (2016-06-04 00:28:58 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-04 01:24:38 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 01:26:31 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/82ed2a35b3a0c8f7398fb3e5ad36577774dced8b
Cr-Commit-Position: refs/heads/master@{#397881}

Powered by Google App Engine
This is Rietveld 408576698