Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issue 2037753005: Rename CFX_GEFont to CFGAS_GEFont (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename CFX_GEFont to CFGAS_GEFont It implements IFGAS_Font and is unrelated to CFX Fonts, except as a wrapper. Committed: https://pdfium.googlesource.com/pdfium/+/d1b859c0bc849759ee57dba000687eef4fee9757

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -59 lines) Patch
M xfa/fgas/font/fgas_gefont.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M xfa/fgas/font/fgas_gefont.cpp View 1 27 chunks +56 lines, -55 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Tom Sepez
Wei, for review.
4 years, 6 months ago (2016-06-03 21:38:34 UTC) #3
Wei Li
lgtm
4 years, 6 months ago (2016-06-03 22:45:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037753005/20001
4 years, 6 months ago (2016-06-03 23:08:40 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 23:22:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d1b859c0bc849759ee57dba000687eef4fee...

Powered by Google App Engine
This is Rietveld 408576698