third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py - Issue 2037743002: Support converting utf-16 files when importing w3c tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

Issue 2037743002: Support converting utf-16 files when importing w3c tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modified files to match Master/Origin (with changes) Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

index ef25fb91c9344e3a0863a1a1642d9149c8403c8c..060667d3ee4d5cd27b51a10e044673b700ac2ef0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py

@@ -47,7 +47,10 @@ def convert_for_webkit(new_path, filename, reference_support_info, host=Host()):

if filename.endswith('.css'):

return converter.add_webkit_prefix_to_unprefixed_properties(contents.decode('utf-8'))

else:

- converter.feed(contents.decode('utf-8'))

+ try:

+ converter.feed(contents.decode('utf-8'))

+ except UnicodeDecodeError:

+ converter.feed(contents.decode('utf-16'))

converter.close()

return converter.output()