Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2037733002: PlzNavigate: fix RenderViewImplTest.OnNavigationHttpPost (Closed)

Created:
4 years, 6 months ago by clamy
Modified:
4 years, 6 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: fix RenderViewImplTest.OnNavigationHttpPost This CL fixes RenderViewImplTest.OnNavigationHttpPost when PlzNavigate is enabled by having RenderFrameImpl::NavigateInternal chose to use LoadDataURL instead of WebLocalFrame::load in the same cases as what the current architecture is doing. It also ensures that the WebURLLoader will not replace the ResourceResponse it receives with one provided by the browser when loading a data url. In this case, the browser has no response to provide. so we should use the one generated by the HandleDataURL task. BUG=475027 Committed: https://crrev.com/269f92ce7d43d77d11674ea7898b6d826eb579d5 Cr-Commit-Position: refs/heads/master@{#398008}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/child/web_url_loader_impl.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
clamy
@nasko:PTAL
4 years, 6 months ago (2016-06-02 17:36:35 UTC) #3
nasko
LGTM
4 years, 6 months ago (2016-06-02 22:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037733002/20001
4 years, 6 months ago (2016-06-06 11:30:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 12:24:42 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 12:26:11 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/269f92ce7d43d77d11674ea7898b6d826eb579d5
Cr-Commit-Position: refs/heads/master@{#398008}

Powered by Google App Engine
This is Rietveld 408576698