Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 203773013: Retrieve current version from trunk branch in push-to-trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Retrieve current version from trunk branch in push-to-trunk. - This moves retrieving and incrementing the version before creating the change log - Before the prepare push commit will be deprecated (follow up CL), the script deals with 3 build levels. X: the current build level on the last trunk push. X + 1: the build level for this trunk push. X + 2: the build level of the new version file on bleeding edge (to be deprecated). BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -49 lines) Patch
M tools/push-to-trunk/git_recipes.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 5 chunks +45 lines, -35 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 9 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-19 12:39:27 UTC) #1
Jakob Kummerow
lgtm
6 years, 9 months ago (2014-03-19 13:09:16 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-19 13:10:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698