Issue 203773012: Removed header include cycles in indexeddb.

Issue 203773012: Removed header include cycles in indexeddb. (Closed)

Created:
6 years, 9 months ago by Dmitry Zvorygin

Modified:
6 years, 9 months ago

Reviewers:
jsbell

CC:
blink-reviews, dgrogan, jsbell+idb_chromium.org, alecflett, ericu+idb_chromium.org, cmumford

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Removed header include cycles in indexeddb. IDBIndex.h -> IDBObjectStore.h -> IDBIndex.h IDBRequest.h -> IDBCursor.h -> IDBRequest.h BUG=353954 R=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169561

Patch Set 2 : Added forward declaration of IDBCursor. #

Total comments: 1

Patch Set 3 : Fixed forward declaration order. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
M	Source/modules/indexeddb/IDBIndex.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/indexeddb/IDBIndex.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/modules/indexeddb/IDBRequest.h	View	1 2	3 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jsbell

Thanks for tackling this. https://codereview.chromium.org/203773012/diff/1/Source/modules/indexeddb/IDBRequest.h File Source/modules/indexeddb/IDBRequest.h (left): https://codereview.chromium.org/203773012/diff/1/Source/modules/indexeddb/IDBRequest.h#oldcode43 Source/modules/indexeddb/IDBRequest.h:43: #include "modules/indexeddb/IDBCursor.h" This file references ...

6 years, 9 months ago (2014-03-19 16:14:37 UTC) #2

Dmitry Zvorygin

Please take a look. https://codereview.chromium.org/203773012/diff/1/Source/modules/indexeddb/IDBRequest.h File Source/modules/indexeddb/IDBRequest.h (left): https://codereview.chromium.org/203773012/diff/1/Source/modules/indexeddb/IDBRequest.h#oldcode43 Source/modules/indexeddb/IDBRequest.h:43: #include "modules/indexeddb/IDBCursor.h" On 2014/03/19 16:14:38, ...

6 years, 9 months ago (2014-03-19 16:42:39 UTC) #3

jsbell

LGTM with nit https://codereview.chromium.org/203773012/diff/20001/Source/modules/indexeddb/IDBRequest.h File Source/modules/indexeddb/IDBRequest.h (right): https://codereview.chromium.org/203773012/diff/20001/Source/modules/indexeddb/IDBRequest.h#newcode50 Source/modules/indexeddb/IDBRequest.h:50: class IDBCursor; Nit: Should be sorted ...

6 years, 9 months ago (2014-03-19 16:47:21 UTC) #4

Dmitry Zvorygin

6 years, 9 months ago (2014-03-19 16:49:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r169561 (presubmit successful).

Expand Messages | Collapse Messages