Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: chrome/common/safe_browsing/permission_report.proto

Issue 2037693004: Change field_trials type to hashes in permission report proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove origin of FieldTrial comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/safe_browsing/permission_report.proto
diff --git a/chrome/common/safe_browsing/permission_report.proto b/chrome/common/safe_browsing/permission_report.proto
index 59dc519e40172ecf2d29e4e4cadd0167b282f421..4abd33dbd8e3cd1ef9dc3b634290b6a4139279c7 100644
--- a/chrome/common/safe_browsing/permission_report.proto
+++ b/chrome/common/safe_browsing/permission_report.proto
@@ -34,9 +34,7 @@ message PermissionReport {
optional SourceUI source_ui = 6;
// The relevant field trials enabled for this report.
- // TODO(stefanocs): Update field_trials field to store hashes instead of
- // string.
- repeated string field_trials = 7;
+ repeated FieldTrial field_trials = 7;
// Platform
enum PlatformType {
@@ -89,4 +87,17 @@ message PermissionReport {
AUDIO_CAPTURE = 8;
VIDEO_CAPTURE = 9;
}
+
+ // Description of a field trial or experiment that the user is currently
+ // enrolled in. All metrics reported in this upload can potentially be
+ // influenced by the field trial.
+ message FieldTrial {
+ // The name of the field trial, as a 32-bit identifier. Currently, the
+ // identifier is a hash of the field trial's name.
+ optional fixed32 name_id = 1;
+
+ // The user's group within the field trial, as a 32-bit identifier.
+ // Currently, the identifier is a hash of the group's name.
+ optional fixed32 group_id = 2;
+ }
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698