Make CronetHttpURLConnection#setConnectTimeout silently fail

Make CronetHttpURLConnection#setConnectTimeout silently fail

This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.

The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).

BUG=611851
TBR=pauljensen@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
(cherry picked from commit 7130ccb5f2fa407a7dd54e221744978475d8b64e)

[xunjieli, 2016-06-02 17:27:06]

Paul, FYI. This is to merge into M52. I will CQ it once I confirm that local
tests pass.

[xunjieli, 2016-06-02 17:33:50]

On 2016/06/02 17:27:06, xunjieli wrote:
> Paul, FYI. This is to merge into M52. I will CQ it once I confirm that local
> tests pass.

Tests are passing.

[xunjieli, 2016-06-02 17:33:52]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-06-02 17:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037683003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037683003/1

[commit-bot: I haz the power, 2016-06-02 17:34:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 17:34:19]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
and NOPRESUBMIT=true in order for the CQ to process them

[xunjieli, 2016-06-02 17:34:50]

Description was changed from

==========
Make CronetHttpURLConnection#setConnectTimeout silently fail

This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.

The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).

BUG=611851

TBR=pauljensen@chromium.org

Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
(cherry picked from commit 7130ccb5f2fa407a7dd54e221744978475d8b64e)
==========

to

==========
Make CronetHttpURLConnection#setConnectTimeout silently fail

This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.

The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).

BUG=611851

TBR=pauljensen@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
(cherry picked from commit 7130ccb5f2fa407a7dd54e221744978475d8b64e)
==========

[xunjieli, 2016-06-02 17:34:53]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-06-02 17:35:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037683003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037683003/1

[commit-bot: I haz the power, 2016-06-02 17:37:43]

Description was changed from

==========
Make CronetHttpURLConnection#setConnectTimeout silently fail

This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.

The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).

BUG=611851

TBR=pauljensen@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
(cherry picked from commit 7130ccb5f2fa407a7dd54e221744978475d8b64e)
==========

to

==========
Make CronetHttpURLConnection#setConnectTimeout silently fail

This CL makes setConnectTimeout to fail silently so we
don't crash applications when this method is called.

The goal of Cronet's HttpURLConnection impl is to
facilitate applications to try out Cronet. In order to
do so, we would like it to be as easy as possible
to drop in Cronet's HttpURLConnection impl without hitting
any exceptions. We should only reserve the use of
exceptions when absolutely necessary (e.g. in matters of
correctness), but not for issues of
sub-optimality (e.g. HTTP cache being ignored).

BUG=611851

TBR=pauljensen@chromium.org

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2030933002
Cr-Commit-Position: refs/heads/master@{#397450}
(cherry picked from commit 7130ccb5f2fa407a7dd54e221744978475d8b64e)
==========

[commit-bot: I haz the power, 2016-06-02 17:37:44]

Committed patchset #1 (id:1)