Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2037653002: Some new/fixed async tests (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
caitp (gmail), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Async/await event listener test This patch adds a test for async/await analogous to a previous Promise test. It also fixes a typo in promise.js and makes a previous Promise test more correct by ensuring that all assertions run before completion, fixing the test expectations for the real result (which seems correct). BUG=v8:4483 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/5d7b9ece164f3179b960d67a93c8a779e494a8ba Cr-Commit-Position: refs/heads/master@{#36903}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Formatting #

Patch Set 4 : Adjust test expectations for Sathya's optimization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M src/js/promise.js View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M test/mjsunit/es6/debug-promises/async-task-event.js View 3 chunks +4 lines, -2 lines 0 comments Download
A + test/mjsunit/harmony/debug-async-function-async-task-event.js View 1 2 3 4 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037653002/1
4 years, 6 months ago (2016-06-02 12:56:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/86734)
4 years, 6 months ago (2016-06-02 14:05:16 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037653002/40001
4 years, 6 months ago (2016-06-06 09:49:40 UTC) #9
Dan Ehrenberg
4 years, 6 months ago (2016-06-06 10:41:43 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 11:15:14 UTC) #12
Dan Ehrenberg
PTAL
4 years, 6 months ago (2016-06-08 08:31:34 UTC) #13
Yang
On 2016/06/08 08:31:34, Dan Ehrenberg wrote: > PTAL lgtm.
4 years, 6 months ago (2016-06-08 08:35:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037653002/40001
4 years, 6 months ago (2016-06-08 08:35:56 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/2868) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-08 08:52:11 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037653002/60001
4 years, 6 months ago (2016-06-10 17:47:45 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-10 19:12:22 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 19:15:43 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5d7b9ece164f3179b960d67a93c8a779e494a8ba
Cr-Commit-Position: refs/heads/master@{#36903}

Powered by Google App Engine
This is Rietveld 408576698