tracing: Reduce memory usage of heap_profiler_allocation_register_unittest.cc

tracing: Reduce memory usage of heap_profiler_allocation_register_unittest.cc

This test was causing flakiness on low-memory devices as it tries to allocate
~600 MB of virtual memory. Turns out the test doesn't really need it all that.
Reducing the number of cells allocated to 54 MB.

BUG=608354
Committed: https://crrev.com/db346b18cb3a494e21d2c4662641eb33e1584212
Cr-Commit-Position: refs/heads/master@{#397484}

[Primiano Tucci (use gerrit), 2016-06-02 10:17:05]

primiano@chromium.org changed reviewers:
+ petrcermak@chromium.org

[petrcermak, 2016-06-02 10:29:38]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-06-02 10:29:38]

lgtm

[commit-bot: I haz the power, 2016-06-02 10:30:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037603002/1

[petrcermak, 2016-06-02 10:30:06]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-06-02 10:31:51]

Sorry, I've just found two things in the description:

"need it all that" -> "need it" or "need all that"
"need [it/all that]. Reducing" -> "need [it/all that], so this patch reduces"

Thanks,
Petr

[bcf, 2016-06-02 18:24:18]

On 2016/06/02 10:31:51, petrcermak wrote:
> Sorry, I've just found two things in the description:
> 
> "need it all that" -> "need it" or "need all that"
> "need [it/all that]. Reducing" -> "need [it/all that], so this patch reduces"
> 
> Thanks,
> Petr

lgtm % Petr's comments

Thanks, this fixes our issue.

[bcf, 2016-06-02 18:25:16]

On 2016/06/02 18:24:18, bcf wrote:
> On 2016/06/02 10:31:51, petrcermak wrote:
> > Sorry, I've just found two things in the description:
> > 
> > "need it all that" -> "need it" or "need all that"
> > "need [it/all that]. Reducing" -> "need [it/all that], so this patch
reduces"
> > 
> > Thanks,
> > Petr
> 
> lgtm % Petr's comments
> 
> Thanks, this fixes our issue.

I wonder if it's worth reverting https://codereview.chromium.org/1954443002 now?

[Dmitry Skiba, 2016-06-02 18:36:31]

On 2016/06/02 18:25:16, bcf wrote:
> On 2016/06/02 18:24:18, bcf wrote:
> > On 2016/06/02 10:31:51, petrcermak wrote:
> > > Sorry, I've just found two things in the description:
> > > 
> > > "need it all that" -> "need it" or "need all that"
> > > "need [it/all that]. Reducing" -> "need [it/all that], so this patch
> reduces"
> > > 
> > > Thanks,
> > > Petr
> > 
> > lgtm % Petr's comments
> > 
> > Thanks, this fixes our issue.
> 
> I wonder if it's worth reverting https://codereview.chromium.org/1954443002
now?

Reverting that will make native heap profiling on Android very flaky (if not
impossible). I.e. we won't be able to use it to investigate memory issues.

[Primiano Tucci (use gerrit), 2016-06-02 18:50:01]

The CQ bit was checked by primiano@chromium.org

[commit-bot: I haz the power, 2016-06-02 18:50:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2037603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2037603002/1

[commit-bot: I haz the power, 2016-06-02 18:55:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-02 18:57:08]

Description was changed from

==========
tracing: Reduce memory usage of heap_profiler_allocation_register_unittest.cc

This test was causing flakiness on low-memory devices as it tries to allocate
~600 MB of virtual memory. Turns out the test doesn't really need it all that.
Reducing the number of cells allocated to 54 MB.

BUG=608354
==========

to

==========
tracing: Reduce memory usage of heap_profiler_allocation_register_unittest.cc

This test was causing flakiness on low-memory devices as it tries to allocate
~600 MB of virtual memory. Turns out the test doesn't really need it all that.
Reducing the number of cells allocated to 54 MB.

BUG=608354

Committed: https://crrev.com/db346b18cb3a494e21d2c4662641eb33e1584212
Cr-Commit-Position: refs/heads/master@{#397484}
==========

[commit-bot: I haz the power, 2016-06-02 18:57:09]

Patchset 1 (id:??) landed as
https://crrev.com/db346b18cb3a494e21d2c4662641eb33e1584212
Cr-Commit-Position: refs/heads/master@{#397484}