Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptArguments.cpp

Issue 2037593004: [DevTools] Remove unnecessary knowledge about console from core. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/ScriptArguments.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp b/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp
index e7c47a56e983f80e67275eb8bad5ec34525292d4..f2ab1ff8ed1efe05ee68ec38b4085ec138f844d4 100644
--- a/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp
+++ b/third_party/WebKit/Source/core/inspector/ScriptArguments.cpp
@@ -91,10 +91,6 @@ private:
}
if (value->IsArray())
return append(v8::Local<v8::Array>::Cast(value));
- if (toDOMWindow(m_isolate, value)) {
kozy 2016/06/03 23:49:17 What will we dump for DOMWindow without this check
dgozman 2016/06/04 00:33:30 This is only for terminal output.
- m_builder.append("[object Window]");
- return true;
- }
if (value->IsProxy()) {
m_builder.append("[object Proxy]");
return true;

Powered by Google App Engine
This is Rietveld 408576698