Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2037583002: [Binding] Get non indexed property names for dense array serialization (Closed)

Created:
4 years, 6 months ago by peria
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get non indexed property names for dense array serialization. Although we already have all own property names to judge if the serializing array is dense or sparse, getting non indexed ones again for dense arrays improves performance of serialization of large scale dense arrays. (For small size arrays and sparse arrays, this CL does not change the performance.) This CL improves a micro-benchmark score of PerformanceTests/Bindings/serialize-array.html from 430ms to 260ms on my local machine. https://chromeperf.appspot.com/report?sid=96d5e4ae4e5a4085541ab88e8672b8836d57d223b759a3d5406a06c0b1a65420 BUG=148757 Committed: https://crrev.com/212bfd8b6f448dcb84a4bb2f46d26c7e1cb28f64 Cr-Commit-Position: refs/heads/master@{#398001}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp View 1 6 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
peria
PTL Thanks to V8 team's work, we can get only non indexed property names of ...
4 years, 6 months ago (2016-06-06 08:35:07 UTC) #4
haraken
LGTM, but do you have a benchmark (in PerformanceTests/Bindings/) to measure performance impacts of your ...
4 years, 6 months ago (2016-06-06 08:38:12 UTC) #5
peria
On 2016/06/06 08:38:12, haraken wrote: > LGTM, but do you have a benchmark (in PerformanceTests/Bindings/) ...
4 years, 6 months ago (2016-06-06 08:45:29 UTC) #7
Yuki
lgtm
4 years, 6 months ago (2016-06-06 08:48:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037583002/20001
4 years, 6 months ago (2016-06-06 08:49:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-06 10:26:43 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 10:27:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/212bfd8b6f448dcb84a4bb2f46d26c7e1cb28f64
Cr-Commit-Position: refs/heads/master@{#398001}

Powered by Google App Engine
This is Rietveld 408576698