Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037573004: Add video width and height to getSettings. (Closed)

Created:
4 years, 6 months ago by hta - Chromium
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, jam, mcasas+watch+vc_chromium.org, mcasas+watch+mediastream_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add video width and height to getSettings. BUG=617142 Committed: https://crrev.com/d1ce26c1f848cc75f8077f1c77c5df5a8a49dca4 Cr-Commit-Position: refs/heads/master@{#398035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M content/renderer/media/media_stream_video_track.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamTrack.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
hta - Chromium
Easy review on a Friday.
4 years, 6 months ago (2016-06-03 13:40:46 UTC) #3
Guido Urdaneta
On 2016/06/03 13:40:46, hta - Chromium wrote: > Easy review on a Friday. lgtm
4 years, 6 months ago (2016-06-03 14:03:53 UTC) #4
tommi (sloooow) - chröme
lgtm
4 years, 6 months ago (2016-06-03 15:29:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2037573004/1
4 years, 6 months ago (2016-06-03 15:29:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/194741)
4 years, 6 months ago (2016-06-03 15:37:04 UTC) #9
hta - Chromium
Forgot to add a reviewer..
4 years, 6 months ago (2016-06-03 15:40:16 UTC) #11
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-06 13:53:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037573004/1
4 years, 6 months ago (2016-06-06 13:58:00 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 15:54:20 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 15:55:50 UTC) #18
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d1ce26c1f848cc75f8077f1c77c5df5a8a49dca4
Cr-Commit-Position: refs/heads/master@{#398035}

Powered by Google App Engine
This is Rietveld 408576698