Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2037573003: Remove FWL_HTIMER in favor of IWFL_TimerInfo (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FWL_HTIMER in favor of IWFL_TimerInfo Committed: https://pdfium.googlesource.com/pdfium/+/6f4f2335cfd22d26db154fbd51ab553fb9902918

Patch Set 1 #

Patch Set 2 : Returned arguments go last and are ** types. #

Patch Set 3 : Remove unused return value. #

Total comments: 8

Patch Set 4 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -115 lines) Patch
M fpdfsdk/fpdfxfa/fpdfxfa_util.cpp View 1 2 chunks +8 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfxfa/include/fpdfxfa_util.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_caretimp.cpp View 1 2 3 4 chunks +12 lines, -15 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_scrollbarimp.cpp View 1 2 4 chunks +13 lines, -15 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fwl/basewidget/fwl_spinbuttonimp.cpp View 1 2 3 5 chunks +17 lines, -14 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 1 2 3 6 chunks +25 lines, -26 lines 0 comments Download
M xfa/fwl/core/fwl_timerimp.cpp View 1 2 chunks +11 lines, -10 lines 0 comments Download
M xfa/fwl/core/ifwl_timer.h View 1 2 1 chunk +10 lines, -6 lines 0 comments Download
M xfa/fwl/core/include/ifwl_adaptertimermgr.h View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom Sepez
Lei, for review.
4 years, 6 months ago (2016-06-03 18:16:04 UTC) #2
Tom Sepez
Dan
4 years, 6 months ago (2016-06-06 19:04:41 UTC) #4
dsinclair
lgtm w/ nits https://codereview.chromium.org/2037573003/diff/40001/xfa/fwl/basewidget/fwl_caretimp.cpp File xfa/fwl/basewidget/fwl_caretimp.cpp (right): https://codereview.chromium.org/2037573003/diff/40001/xfa/fwl/basewidget/fwl_caretimp.cpp#newcode72 xfa/fwl/basewidget/fwl_caretimp.cpp:72: m_pTimerInfo = NULL; nit: nullptr https://codereview.chromium.org/2037573003/diff/40001/xfa/fwl/basewidget/fwl_spinbuttonimp.cpp ...
4 years, 6 months ago (2016-06-06 19:52:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037573003/60001
4 years, 6 months ago (2016-06-06 20:06:56 UTC) #8
Tom Sepez
https://codereview.chromium.org/2037573003/diff/40001/xfa/fwl/basewidget/fwl_caretimp.cpp File xfa/fwl/basewidget/fwl_caretimp.cpp (right): https://codereview.chromium.org/2037573003/diff/40001/xfa/fwl/basewidget/fwl_caretimp.cpp#newcode72 xfa/fwl/basewidget/fwl_caretimp.cpp:72: m_pTimerInfo = NULL; On 2016/06/06 19:52:21, dsinclair wrote: > ...
4 years, 6 months ago (2016-06-06 20:08:33 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:24:00 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6f4f2335cfd22d26db154fbd51ab553fb990...

Powered by Google App Engine
This is Rietveld 408576698