Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2037533002: mus: Make --use-mus-in-renderer work again. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Make --use-mus-in-renderer work again. . It is necessary to send the --use-mus-in-renderer flag to the renderer. . Allow content_browser to connect to the renderer and get a handle to a RenderWidgetWindowTreeClientFactory. BUG=none Committed: https://crrev.com/ff71d680cd19972540c72d9f72b56833ef358275 Cr-Commit-Position: refs/heads/master@{#397759}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sadrul
4 years, 6 months ago (2016-06-02 04:57:27 UTC) #2
Ben Goodger (Google)
https://codereview.chromium.org/2037533002/diff/1/content/public/app/mojo/content_renderer_manifest.json File content/public/app/mojo/content_renderer_manifest.json (right): https://codereview.chromium.org/2037533002/diff/1/content/public/app/mojo/content_renderer_manifest.json#newcode7 content/public/app/mojo/content_renderer_manifest.json:7: "app": [ "content::mojom::RenderWidgetWindowTreeClientFactory" ] I think you should explicitly ...
4 years, 6 months ago (2016-06-02 17:48:56 UTC) #3
sadrul
https://codereview.chromium.org/2037533002/diff/1/content/public/app/mojo/content_renderer_manifest.json File content/public/app/mojo/content_renderer_manifest.json (right): https://codereview.chromium.org/2037533002/diff/1/content/public/app/mojo/content_renderer_manifest.json#newcode7 content/public/app/mojo/content_renderer_manifest.json:7: "app": [ "content::mojom::RenderWidgetWindowTreeClientFactory" ] On 2016/06/02 17:48:56, Ben Goodger ...
4 years, 6 months ago (2016-06-03 07:44:18 UTC) #5
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-03 17:43:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037533002/20001
4 years, 6 months ago (2016-06-03 18:16:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-03 18:21:10 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 18:22:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff71d680cd19972540c72d9f72b56833ef358275
Cr-Commit-Position: refs/heads/master@{#397759}

Powered by Google App Engine
This is Rietveld 408576698