Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 203753010: Deprecate prepare push commit when pushing to trunk. (Closed)

Created:
6 years, 9 months ago by Michael Achenbach
Modified:
6 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev, Jarin
Visibility:
Public.

Description

Deprecate prepare push commit when pushing to trunk. - This also deprecates using version.cc on bleeding edge. - The deprecated push-to-trunk.sh is deleted. - The script now commits bleeding edge HEAD by default. Committing different revisions will be added in a follow up CL. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -490 lines) Patch
M src/version.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D tools/push-to-trunk.sh View 1 chunk +0 lines, -412 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 7 chunks +8 lines, -52 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +3 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 9 months ago (2014-03-19 14:15:04 UTC) #1
Jakob Kummerow
lgtm
6 years, 9 months ago (2014-03-19 16:28:29 UTC) #2
Michael Achenbach
6 years, 9 months ago (2014-03-20 09:23:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698