Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2037523003: Fix for SDK summary result provider. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for SDK summary result provider. Unfortunately the problem was uncovered only in the check mode. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f91de5fef16dbdb616d13bbe17f3062958d308a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M pkg/analyzer/lib/src/summary/package_bundle_reader.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-02 18:45:57 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-02 18:57:16 UTC) #2
scheglov
4 years, 6 months ago (2016-06-02 19:24:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f91de5fef16dbdb616d13bbe17f3062958d308a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698