Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2037523002: Select precache resources based on field trial experiment group (Closed)

Created:
4 years, 6 months ago by Raj
Modified:
4 years, 6 months ago
Reviewers:
bengr, twifkak
CC:
chromium-reviews, darin-cc_chromium.org, jam, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Select precache resources based on field trial experiment group Resource manifest will include bitset of the resources to be fetched based on the fieldtrial experiment id. BUG=616675 Committed: https://crrev.com/e71ee4f99e0b249722b20051ea2db80f4071d012 Cr-Commit-Position: refs/heads/master@{#397935}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments, added more test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -58 lines) Patch
M components/precache/content/precache_manager.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M components/precache/core/precache_fetcher.h View 2 chunks +9 lines, -6 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 1 3 chunks +21 lines, -2 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 1 14 chunks +177 lines, -44 lines 0 comments Download
M components/precache/core/proto/precache.proto View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Raj
4 years, 6 months ago (2016-06-02 04:41:02 UTC) #2
twifkak
lgtm https://codereview.chromium.org/2037523002/diff/1/components/precache/core/precache_fetcher_unittest.cc File components/precache/core/precache_fetcher_unittest.cc (right): https://codereview.chromium.org/2037523002/diff/1/components/precache/core/precache_fetcher_unittest.cc#newcode447 components/precache/core/precache_fetcher_unittest.cc:447: resource_selection.set_bitset(0x15); How about 0b10101 ?
4 years, 6 months ago (2016-06-02 22:28:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037523002/40001
4 years, 6 months ago (2016-06-04 19:09:52 UTC) #7
Raj
https://codereview.chromium.org/2037523002/diff/1/components/precache/core/precache_fetcher_unittest.cc File components/precache/core/precache_fetcher_unittest.cc (right): https://codereview.chromium.org/2037523002/diff/1/components/precache/core/precache_fetcher_unittest.cc#newcode447 components/precache/core/precache_fetcher_unittest.cc:447: resource_selection.set_bitset(0x15); On 2016/06/02 22:28:24, twifkak wrote: > How about ...
4 years, 6 months ago (2016-06-04 19:09:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-04 19:13:41 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 19:15:32 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e71ee4f99e0b249722b20051ea2db80f4071d012
Cr-Commit-Position: refs/heads/master@{#397935}

Powered by Google App Engine
This is Rietveld 408576698