Issue 2037473002: Check for extension methods when using whitelist

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2037473002: Check for extension methods when using whitelist (Closed)

Created:
4 years, 6 months ago by Leaf

Modified:
4 years, 6 months ago

Reviewers:
Jacob

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Check for extension methods when using whitelist BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/722f97942e2413306ef16d3c5152337938974e8c

Patch Set 3 : #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
	M	lib/src/compiler/code_generator.dart	View	1 2	4 chunks	+28 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

lgtm https://codereview.chromium.org/2037473002/diff/1/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2037473002/diff/1/lib/src/compiler/code_generator.dart#newcode3898 lib/src/compiler/code_generator.dart:3898: js.call('(#[dart._extensionType]) ? #[dartx[#]] : #.#', [l, l, name, ...

4 years, 6 months ago (2016-06-02 03:07:51 UTC) #2

Leaf

4 years, 6 months ago (2016-06-02 03:45:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
722f97942e2413306ef16d3c5152337938974e8c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2037473002: Check for extension methods when using whitelist (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages