Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Side by Side Diff: Source/core/css/RuleFeature.cpp

Issue 203743002: Fix "unreachable code" warnings (MSVC warning 4702) in Blink. (Closed) Base URL: svn://svn.chromium.org/blink/trunk/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/core.gyp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 case CSSSelector::PseudoLang: 98 case CSSSelector::PseudoLang:
99 case CSSSelector::PseudoRoot: 99 case CSSSelector::PseudoRoot:
100 case CSSSelector::PseudoScope: 100 case CSSSelector::PseudoScope:
101 case CSSSelector::PseudoInRange: 101 case CSSSelector::PseudoInRange:
102 case CSSSelector::PseudoOutOfRange: 102 case CSSSelector::PseudoOutOfRange:
103 case CSSSelector::PseudoUnresolved: 103 case CSSSelector::PseudoUnresolved:
104 return true; 104 return true;
105 default: 105 default:
106 return false; 106 return false;
107 } 107 }
108 ASSERT_NOT_REACHED();
109 return false;
110 } 108 }
111 109
112 // This method is somewhat conservative in what it accepts. 110 // This method is somewhat conservative in what it accepts.
113 RuleFeatureSet::InvalidationSetMode RuleFeatureSet::supportsClassDescendantInval idation(const CSSSelector& selector) 111 RuleFeatureSet::InvalidationSetMode RuleFeatureSet::supportsClassDescendantInval idation(const CSSSelector& selector)
114 { 112 {
115 bool foundDescendantRelation = false; 113 bool foundDescendantRelation = false;
116 bool foundIdent = false; 114 bool foundIdent = false;
117 for (const CSSSelector* component = &selector; component; component = compon ent->tagHistory()) { 115 for (const CSSSelector* component = &selector; component; component = compon ent->tagHistory()) {
118 116
119 // FIXME: next up: Tag and Id. 117 // FIXME: next up: Tag and Id.
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 } 457 }
460 458
461 invalidationClasses.remove(oldSize, invalidationClasses.size() - oldSize); 459 invalidationClasses.remove(oldSize, invalidationClasses.size() - oldSize);
462 element->clearChildNeedsStyleInvalidation(); 460 element->clearChildNeedsStyleInvalidation();
463 element->clearNeedsStyleInvalidation(); 461 element->clearNeedsStyleInvalidation();
464 462
465 return thisElementNeedsStyleRecalc; 463 return thisElementNeedsStyleRecalc;
466 } 464 }
467 465
468 } // namespace WebCore 466 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/core.gyp ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698