Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: Source/core/css/RuleFeature.cpp

Issue 203743002: Fix "unreachable code" warnings (MSVC warning 4702) in Blink. (Closed) Base URL: svn://svn.chromium.org/blink/trunk/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 case CSSSelector::PseudoLang: 88 case CSSSelector::PseudoLang:
89 case CSSSelector::PseudoRoot: 89 case CSSSelector::PseudoRoot:
90 case CSSSelector::PseudoScope: 90 case CSSSelector::PseudoScope:
91 case CSSSelector::PseudoInRange: 91 case CSSSelector::PseudoInRange:
92 case CSSSelector::PseudoOutOfRange: 92 case CSSSelector::PseudoOutOfRange:
93 case CSSSelector::PseudoUnresolved: 93 case CSSSelector::PseudoUnresolved:
94 return true; 94 return true;
95 default: 95 default:
96 return false; 96 return false;
97 } 97 }
98 ASSERT_NOT_REACHED();
99 return false;
100 } 98 }
101 99
102 // This method is somewhat conservative in what it accepts. 100 // This method is somewhat conservative in what it accepts.
103 static bool supportsClassDescendantInvalidation(const CSSSelector& selector) 101 static bool supportsClassDescendantInvalidation(const CSSSelector& selector)
104 { 102 {
105 bool foundDescendantRelation = false; 103 bool foundDescendantRelation = false;
106 bool foundIdent = false; 104 bool foundIdent = false;
107 for (const CSSSelector* component = &selector; component; component = compon ent->tagHistory()) { 105 for (const CSSSelector* component = &selector; component; component = compon ent->tagHistory()) {
108 106
109 // FIXME: We should allow pseudo elements, but we need to change how the y hook 107 // FIXME: We should allow pseudo elements, but we need to change how the y hook
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 } 442 }
445 443
446 invalidationClasses.remove(oldSize, invalidationClasses.size() - oldSize); 444 invalidationClasses.remove(oldSize, invalidationClasses.size() - oldSize);
447 element->clearChildNeedsStyleInvalidation(); 445 element->clearChildNeedsStyleInvalidation();
448 element->clearNeedsStyleInvalidation(); 446 element->clearNeedsStyleInvalidation();
449 447
450 return thisElementNeedsStyleRecalc; 448 return thisElementNeedsStyleRecalc;
451 } 449 }
452 450
453 } // namespace WebCore 451 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698