Fix "unreachable code" warnings (MSVC warning 4702) in Blink.

Source/build/scripts/make_css_value_keywords.py

 #!/usr/bin/env python
 
 import os.path
 import re
 import subprocess
 import sys
 
 from in_file import InFile
 import in_generator
 import license
@@ skipping 68 matching lines @@
 
 const char* getValueName(unsigned short id)
 {
     if (id >= numCSSValueKeywords || id <= 0)
         return 0;
     return valueListStringPool + valueListStringOffsets[id];
 }
 
 bool isValueAllowedInMode(unsigned short id, CSSParserMode mode)
 {
-    // FIXME: Investigate whether we can deprecate the former
-    // two as only QuirksOrUASheet is used in CSSValueKeyword.in

[Peter Kasting, 2014/03/18 17:40:47]

(ua_sheet_mode_values_keywords cannot be removed as it is used by cases in this
file which set the 'mode' property to 'UASheet')

     switch (id) {
         %(ua_sheet_mode_values_keywords)s
             return isUASheetBehavior(mode);
-        %(quirks_mode_values_keywords)s
-            return isQuirksModeBehavior(mode);

[Nico, 2014/03/18 17:47:51]

I don't understand this part. Is this always dead? (+keishi, kenneth)

[Peter Kasting, 2014/03/18 20:58:04]

No keywords in CSSValueKeyword.in use it, and nothing in this file uses it
either; removing it doesn't cause any problems.  Leaving it causes problems
because the generated code has no cases, so we get code like this:

    ...
    case blah_ua_sheet:
    case xyz_ua_sheet:
        return isUASheetBehavior(mode);
        return isQuirksModeBehavior(mode);
    case blah_quirks_or_ua:
    ...

However, "quirks_mode_or_ua_sheet_mode_values_keywords" (below) is not dead, so
the isQuirksModeBehavior() routine cannot go away.

[Nico, 2014/03/19 10:20:05]

Ah, now I understand your comment about lines 89,90, thanks :-)

         %(quirks_mode_or_ua_sheet_mode_values_keywords)s
             return isUASheetBehavior(mode) || isQuirksModeBehavior(mode);
         default:
             return true;
     }
 }
 
 } // namespace WebCore
 """
 
@@ skipping 51 matching lines @@
             keyword_offsets.append(current_offset)
             current_offset += len(keyword["name"]) + 1
 
         gperf_input = GPERF_TEMPLATE % {
             'license': license.license_for_generated_cpp(),
             'class_name': self.class_name,
             'value_keyword_strings': '\n'.join(map(lambda property: '    "%(name)s\\0"' % property, self._value_keywords)),
             'value_keyword_offsets': '\n'.join(map(lambda offset: '  %d,' % offset, keyword_offsets)),
             'value_keyword_to_enum_map': '\n'.join(map(lambda property: '%(name)s, %(enum_name)s' % property, self._value_keywords)),
             'ua_sheet_mode_values_keywords': '\n        '.join(map(self._case_value_keyword, self._value_keywords_with_mode('UASheet'))),
-            'quirks_mode_values_keywords': '\n        '.join(map(self._case_value_keyword, self._value_keywords_with_mode('Quirks'))),
             'quirks_mode_or_ua_sheet_mode_values_keywords': '\n    '.join(map(self._case_value_keyword, self._value_keywords_with_mode('QuirksOrUASheet'))),
         }
         # FIXME: If we could depend on Python 2.7, we would use subprocess.check_output
         gperf_args = [self.gperf_path, '--key-positions=*', '-P', '-n']
         gperf_args.extend(['-m', '50'])  # Pick best of 50 attempts.
         gperf_args.append('-D')  # Allow duplicate hashes -> More compact code.
         gperf = subprocess.Popen(gperf_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, universal_newlines=True)
         return gperf.communicate(gperf_input)[0]
 
 
 if __name__ == "__main__":
     in_generator.Maker(CSSValueKeywordsWriter).main(sys.argv)