src/effects/gradients/SkGradientShader.cpp - Issue 2037413002: Add SkSourceGammaTreatment enum so we know how to create mips

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkGradientShader.cpp

Issue 2037413002: Add SkSourceGammaTreatment enum so we know how to create mips (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove leftover comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkGradientShader.cpp

diff --git a/src/effects/gradients/SkGradientShader.cpp b/src/effects/gradients/SkGradientShader.cpp

index 3c4784702ab36cadf12544fd6fe961864b5fe9b0..7ce21ce4e92ece8cbc874533c8cc665f5e7cb002 100644

--- a/src/effects/gradients/SkGradientShader.cpp

+++ b/src/effects/gradients/SkGradientShader.cpp

@@ -1131,7 +1131,7 @@ GrGradientEffect::GrGradientEffect(GrContext* ctx,

fCoordTransform.reset(kCoordSet, matrix, fAtlas->getTexture(), params.filterMode());

fTextureAccess.reset(fAtlas->getTexture(), params);

} else {

- SkAutoTUnref<GrTexture> texture(GrRefCachedBitmapTexture(ctx, bitmap, params));

+ SkAutoTUnref<GrTexture> texture(GrRefCachedBitmapTexture(ctx, bitmap, params, false));

if (!texture) {

return;

}