[css-grid] Fix definite/indefinite size detection on block axis

third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index 8fa39a5c14e57891d8c5695f4375d5eca196f561..b8ad7c605f820bd2d813b155292826cb3d20ada4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -234,7 +234,7 @@ void LayoutBlockFlow::checkForPaginationLogicalHeightChange(LayoutUnit& pageLogi
         // definite, or we might fool ourselves into believing that columns have a definite height
         // when they in fact don't.
         LayoutUnit columnHeight;
-        if (hasDefiniteLogicalHeight() || isLayoutView()) {
+        if (!firstInFlowChildBox() || firstInFlowChildBox()->percentageLogicalHeightIsResolvable() || isLayoutView()) {

[cbiesinger, 2016/06/07 20:21:12]

Can you add a comment here explaining the firstInFlowChildBox() logic, so it's
clearer to future readers? Same in LayoutGrid

[Manuel Rego, 2016/06/08 12:10:24]

Yeah, I'll add a comment.

             LogicalExtentComputedValues computedValues;
             computeLogicalHeight(LayoutUnit(), logicalTop(), computedValues);
             columnHeight = computedValues.m_extent - borderAndPaddingLogicalHeight() - scrollbarLogicalHeight();