Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html

Issue 2037383002: [css-grid] Fix definite/indefinite size detection on block axis (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix-percentage-widths
Patch Set: New version getting rid of hasDefiniteLogicalHeight() Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html
new file mode 100644
index 0000000000000000000000000000000000000000..906913d8cbf3c842b56671c8f130eff8eacadfbe
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/flex-item-grid-container-percentage-rows.html
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+
+.flex {
+ display: flex;
+ flex-direction: column;
+ width: 200px;
+ height: 200px;
+ border: 5px solid;
+}
+
+.flexitem {
+ flex: 1;
+ background: magenta;
+}
+
+.grid {
+ display: grid;
+ grid: 50% / 1fr;
+}
+
+.griditem {
+ background: cyan;
+}
+
+</style>
+
+<p>This test checks that percentage rows are properly resolved for a grid container that is a flex item with a definite height.</p>
+<p>Test passes if you see a 200x200 box with top half cyan and bottom half magenta.</p>
+
+<div class="flex">
+ <div class="flexitem grid">
+ <div class="griditem"></div>
+ </div>
+</div>

Powered by Google App Engine
This is Rietveld 408576698