[css-grid] Fix definite/indefinite size detection on block axis

third_party/WebKit/Source/core/layout/LayoutBox.cpp

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 1cbedcad8db3996a92f175d35cad6c5aeda90a76..8da0e4926367ac8fd41d829a3a7463ab4a6836c4 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -4285,16 +4285,14 @@ bool LayoutBox::percentageLogicalHeightIsResolvable() const
 bool LayoutBox::hasDefiniteLogicalHeight() const
 {
     const Length& logicalHeight = style()->logicalHeight();
-    if (logicalHeight.isIntrinsicOrAuto())
-        return false;
     if (logicalHeight.isFixed())
         return true;
-    // The size of the containing block of an absolutely positioned element is always definite with respect to that
-    // element (http://dev.w3.org/csswg/css-sizing-3/#definite).
-    if (isOutOfFlowPositioned())
+    if (isOutOfFlowPositioned() && !style()->logicalTop().isAuto() && !style()->logicalBottom().isAuto())
         return true;
     if (hasOverrideContainingBlockLogicalHeight())
         return overrideContainingBlockContentLogicalHeight() != -1;
+    if (logicalHeight.isIntrinsicOrAuto())
+        return false;

[cbiesinger1, 2016/06/06 16:46:02]

This is not correct, if a grid is a flex item it can have a definite height even
with height:auto. You'll have to do something like this:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/layout/La...

And compare to -1

[Manuel Rego, 2016/06/07 09:05:55]

Yes, this is wrong for those cases.
But it was already failing before this patch,
I've reported the bug #617876 to track this.

 
     return percentageLogicalHeightIsResolvable();
 }