Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2037373003: tools/android/loading Fix precision and formatting issues in frontend (Closed)

Created:
4 years, 6 months ago by droger
Modified:
4 years, 6 months ago
Reviewers:
mattcary
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/android/loading Fix precision and formatting issues in frontend Fix rounding issue: int(x + 0.5) does not round up correctly. This should be round(x+0.5) or math.ceil(x). Fix formatting issue: the timeout is a float, and should be printed using %f instead of %i. Committed: https://crrev.com/89521b32d117da52d09a28419caf3ca303f3b761 Cr-Commit-Position: refs/heads/master@{#398277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M tools/android/loading/cloud/frontend/clovis_frontend.py View 3 chunks +4 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
droger
4 years, 6 months ago (2016-06-06 14:33:14 UTC) #3
mattcary
lgtm
4 years, 6 months ago (2016-06-06 14:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037373003/1
4 years, 6 months ago (2016-06-07 11:49:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 12:32:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 12:33:51 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89521b32d117da52d09a28419caf3ca303f3b761
Cr-Commit-Position: refs/heads/master@{#398277}

Powered by Google App Engine
This is Rietveld 408576698