Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2037373002: Remove the use of OwnedPtrDeleter in ImageDecoder. (Closed)

Created:
4 years, 6 months ago by Yuta Kitamura
Modified:
4 years, 6 months ago
Reviewers:
urvang, *tzik
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the use of OwnedPtrDeleter in ImageDecoder. It's hard to mechanically replace specializations of OwnedPtrDeleter<T> to std::unique_ptr equivalents. Therefore, they are converted to std::unique_ptr manually. New typedefs named XXXXUniquePtr is introduced so people can always use std::unique_ptr with a correct deleter. BUG=617504 Committed: https://crrev.com/b2ba5dac4355691372f643a0af03681769dae2c7 Cr-Commit-Position: refs/heads/master@{#398319}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move QCMSProfileDeleter to .cpp file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 2 chunks +8 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 1 4 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037373002/1
4 years, 6 months ago (2016-06-06 09:33:25 UTC) #2
Yuta Kitamura
tzik & urvang: PTAL? +urvang for platform/image-decoders/ approval.
4 years, 6 months ago (2016-06-06 09:37:30 UTC) #5
tzik
lgtm
4 years, 6 months ago (2016-06-06 09:41:41 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 10:39:57 UTC) #8
urvang
https://codereview.chromium.org/2037373002/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2037373002/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode64 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:64: struct QCMSProfileDeleter { 64 to 72 can technically be ...
4 years, 6 months ago (2016-06-06 15:56:03 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037373002/20001
4 years, 6 months ago (2016-06-07 05:25:09 UTC) #11
Yuta Kitamura
urvang: PTAL again? https://codereview.chromium.org/2037373002/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right): https://codereview.chromium.org/2037373002/diff/1/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h#newcode64 third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:64: struct QCMSProfileDeleter { On 2016/06/06 15:56:03, ...
4 years, 6 months ago (2016-06-07 05:25:40 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 09:02:04 UTC) #14
urvang
lgtm
4 years, 6 months ago (2016-06-07 17:11:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037373002/20001
4 years, 6 months ago (2016-06-07 17:12:01 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 17:16:30 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 17:17:49 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b2ba5dac4355691372f643a0af03681769dae2c7
Cr-Commit-Position: refs/heads/master@{#398319}

Powered by Google App Engine
This is Rietveld 408576698