Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2037323002: Make SVGLength store a const CSSValue (Closed)

Created:
4 years, 6 months ago by sashab
Modified:
4 years, 5 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@_make_parser_addProperty_take_const
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SVGLength store a const CSSValue Make SVGLength::m_value a Member<const CSSPrimitiveValue> instead of non-const. This also involved making Element::addPropertyToPresentationAttributeStyle take a const ptr, and MutableStylePropertySet::setProperty() take a const ptr. This is an entirely mechanical change that is more semantically correct and safe, and is pre-work for making CSSPropertyParser::parseSingleValue return a const CSSValue*. BUG=526586 Committed: https://crrev.com/9f6e34ef3e17ac61de39b9922e9779ed1b4c4ac4 Cr-Commit-Position: refs/heads/master@{#405443}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebased onto master #

Patch Set 6 : g clt #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/Element.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLength.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
sashab
4 years, 6 months ago (2016-06-06 01:40:11 UTC) #2
Timothy Loh
On 2016/06/06 01:40:11, sashab wrote: lgtm
4 years, 6 months ago (2016-06-06 03:01:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037323002/80001
4 years, 6 months ago (2016-06-09 06:04:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/79098) cast_shell_android on tryserver.chromium.android (JOB_FAILED, ...
4 years, 6 months ago (2016-06-09 06:14:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2037323002/120001
4 years, 5 months ago (2016-07-14 05:12:20 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-14 07:03:47 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 07:06:32 UTC) #14
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/9f6e34ef3e17ac61de39b9922e9779ed1b4c4ac4
Cr-Commit-Position: refs/heads/master@{#405443}

Powered by Google App Engine
This is Rietveld 408576698