Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2037243002: More Unref GrXPFactory. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
herb_g, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

More Unref GrXPFactory. Not releasing the reference was caught by the Skia asan bot. All remaining occurences of this pattern have been updated. This fixes "Make GrClipMaskManager stateless and push GrPipelineBuilder construction downstack". TBR=herb Committed: https://skia.googlesource.com/skia/+/7062d01a338d28e878c3c28469f84d2af1389796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037243002/1
4 years, 6 months ago (2016-06-03 23:55:53 UTC) #6
robertphillips
lgtm
4 years, 6 months ago (2016-06-03 23:59:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037243002/1
4 years, 6 months ago (2016-06-04 00:42:29 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-04 00:43:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7062d01a338d28e878c3c28469f84d2af1389796

Powered by Google App Engine
This is Rietveld 408576698